[ENH] Proto defs for collection version file. #950 #3453
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please tag your PR title with one of: [ENH | BUG | DOC | TST | BLD | PERF | TYP | CLN | CHORE]. See https://docs.trychroma.com/contributing#contributing-code-and-ideas |
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
rohitcpbot
changed the title
rohitcpbot
changed the title
rohitcpbot
commented
Jan 9, 2025
idl/chromadb/proto/coordinator.proto
Outdated
| // NOTE: As of now, we only support version change due to data compaction. | ||
| // There is a good chance to include other reasons in the future, especially | ||
| // for DDL operations, recovery, etc. | ||
| enum VersionChangeReason { |
There was a problem hiding this comment.
If this feels like over-engineering at this point, then i will just remove this. And add it later if/when we decide to increase versions for non-compaction purposes.
Includes proto for storing VersionHistory file, and new GRPCs in SysDb. There will be few more to support the GC tool/server that will follow later.
rohitcpbot
force-pushed
the
rcp/GC-Protos-GI950
branch
from
8b39781 to
1c5c497
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Proto definitions and GRPC defs for supporting Versioned Collections.
Part of GC work.
Summarize the changes made by this PR.
Test plan
How are these changes tested?
pytestfor python,yarn testfor js,cargo testfor rustDocumentation Changes
Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?
n/a