[ENH] Add num_records_last_compaction to sysdb

[drewkim]

Description of changes

Summarize the changes made by this PR.

• New functionality
  • Adds num_records_last_compaction to distributed sysdb

Test plan

How are these changes tested?

• Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?

[github-actions]

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

• Can you think of any use case in which the code does not behave as intended? Have they been tested?
• Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
• If appropriate, are there adequate property based tests?
• If appropriate, are there adequate unit tests?
• Should any logging, debugging, tracing information be added or removed?
• Are error messages user-friendly?
• Have all documentation changes needed been made?
• Have all non-obvious changes been commented?

System Compatibility

• Are there any potential impacts on other parts of the system or backward compatibility?
• Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

• Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

[drewkim]

• [ENH] Update compactor to flush total records upon compaction #3483
• [ENH] Add num_records_last_compaction to sysdb #3463 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[rohitcpbot]

I only saw the proto changes, and some bit of golang changes.
My main question is - why are we passing record count via Create and Update as opposed to something like FlushCollectionCompaction.

[rohitcpbot]

sysdb side of changes looks good to me.
Just keep in mind that when you make the schema change, the existing rows will have a value "NULL" for the new field.
Since, we use gorm, it will set the value to 0, so for existing rows sysdb will return 0 for total_records field. Keep this in mind when you deploy and consume this field.