Skip to content

[ENH] Add a simple rate limiter for async. #3476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 14, 2025
Merged

Conversation

rescrv
Copy link
Contributor

@rescrv rescrv commented Jan 13, 2025

This adds a rate limiter at the level of the fast api async code. The
reason for doing this is that by the time stuff gets to the pool,
there's a queue. We want to try and make the rate limiter async so that
we can avoid said queue.

Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@rescrv rescrv requested a review from drewkim January 13, 2025 21:17
Copy link
Contributor

@drewkim drewkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: I'm unsure we need to wrap get_user_identity, create_database, get_database, create_tenant, get_tenant, list_databases, list_collections, count_collections, or create_collection. These operations don't take in a collection which our rate limiting is dependent on. Not blocking.

@rescrv rescrv force-pushed the rescrv/async-rate-limit branch from 13a2833 to 2532124 Compare January 14, 2025 16:20
This adds a rate limiter at the level of the fast api async code.  The
reason for doing this is that by the time stuff gets to the pool,
there's a queue.  We want to try and make the rate limiter async so that
we can avoid said queue.
@rescrv rescrv force-pushed the rescrv/async-rate-limit branch from 2532124 to b0dad71 Compare January 14, 2025 16:48
@rescrv rescrv merged commit 82f769c into main Jan 14, 2025
78 checks passed
@rescrv rescrv deleted the rescrv/async-rate-limit branch January 14, 2025 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants