Skip to content

[BUG]: keep track of current span if task must be queued #3548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

codetheweb
Copy link
Contributor

@codetheweb codetheweb commented Jan 23, 2025

Description of changes

When a task is dispatched and there's no available worker thread the task is put into a queue. We weren't holding the current span at time of task creation in the queue, leading to mysteriously missing span trees. This was especially apparent under high concurrent load or when the configuration specified a low number of worker threads.

Test plan

How are these changes tested?

Verified that formerly missing spans now show up in Jaeger, especially when num_worker_threads is 1.

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?

n/a

Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@codetheweb codetheweb marked this pull request as ready for review January 23, 2025 21:19
@codetheweb codetheweb enabled auto-merge (squash) January 23, 2025 21:20
@codetheweb codetheweb merged commit bf29ead into main Jan 23, 2025
79 checks passed
@codetheweb codetheweb deleted the bug-missing-spans-in-operators branch January 23, 2025 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant