[BUG]: keep track of current span if task must be queued #3548
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
When a task is dispatched and there's no available worker thread the task is put into a queue. We weren't holding the current span at time of task creation in the queue, leading to mysteriously missing span trees. This was especially apparent under high concurrent load or when the configuration specified a low number of worker threads.
Test plan
How are these changes tested?
Verified that formerly missing spans now show up in Jaeger, especially when
num_worker_threads
is 1.Documentation Changes
Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?
n/a