Skip to content

[ENH] Add rust frontend stub #3549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 23, 2025
Merged

[ENH] Add rust frontend stub #3549

merged 2 commits into from
Jan 23, 2025

Conversation

HammadB
Copy link
Collaborator

@HammadB HammadB commented Jan 23, 2025

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • /
  • New functionality
    • Adds a rust-based frontend stub
    • Adds the frontend to the k8s tiltfile

Test plan

How are these changes tested?
Confirmed I can tilt up and curl the service at :3000

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

None required.

@github-actions GitHub Actions
Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@github-actions GitHub Actions
Copy link

⚠️ The Helm chart was updated without a version bump. Your changes will only be published if the version field in k8s/distributed-chroma/Chart.yaml is updated.

@HammadB
Copy link
Collaborator Author

HammadB commented Jan 23, 2025 •
edited
Loading

  1. Intentionally not bumping helm version, as to not upset staging.
  2. This was pair written with @sanketkedia - implicit PR review

@HammadB HammadB enabled auto-merge (squash) January 23, 2025 21:39
@HammadB HammadB disabled auto-merge January 23, 2025 21:41
@HammadB HammadB merged commit 7c11224 into main Jan 23, 2025
75 of 76 checks passed
@HammadB HammadB mentioned this pull request Jan 23, 2025
Merged
1 task
HammadB added a commit that referenced this pull request Jan 24, 2025
@HammadB
[ENH] Bump helm chart for rust fe (#3554)
e4ec7f3 
## Description of changes

*Summarize the changes made by this PR.*
 - Improvements & Bug fixes
   - Bumps helm chart to release rust FE from #3549 
 - New functionality
   - None

## Test plan
*How are these changes tested?*
- [x] Tests pass locally with `pytest` for python, `yarn test` for js,
`cargo test` for rust

## Documentation Changes
None
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@HammadB