Skip to content

[ENH] Implement multiple member assignment #3553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 24, 2025

Conversation

Sicheng-Pan
Copy link
Contributor

@Sicheng-Pan Sicheng-Pan commented Jan 23, 2025

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • N/A
  • New functionality
    • Implements the multi assignment logic, which allows to deterministically assign multiple members for a given key and hasher. This mirrors the Python implementation.

Test plan

How are these changes tested?

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?

Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

Copy link
Contributor Author

Sicheng-Pan commented Jan 23, 2025

@Sicheng-Pan Sicheng-Pan marked this pull request as ready for review January 23, 2025 23:52
Copy link
Collaborator

@HammadB HammadB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we copy the python testing?

def test_even_distribution() -> None:

def test_multi_assign_even_distribution() -> None:

@Sicheng-Pan Sicheng-Pan changed the title [ENH] Allow multiple assignment [ENH] Implement multiple member assignment Jan 23, 2025
@Sicheng-Pan
Copy link
Contributor Author

Can we copy the python testing?

def test_even_distribution() -> None:

def test_multi_assign_even_distribution() -> None:

I've migrated the tests

Copy link
Contributor Author

Sicheng-Pan commented Jan 24, 2025

Merge activity

  • Jan 23, 8:20 PM EST: A user started a stack merge that includes this pull request via Graphite.
  • Jan 23, 9:12 PM EST: Graphite rebased this pull request as part of a merge.
  • Jan 23, 10:01 PM EST: A user merged this pull request with Graphite.

@Sicheng-Pan Sicheng-Pan changed the base branch from 01-23-_cln_move_memberlist_and_assignment_module_out_of_worker_crate to graphite-base/3553 January 24, 2025 01:21
@Sicheng-Pan Sicheng-Pan changed the base branch from graphite-base/3553 to main January 24, 2025 02:10
@Sicheng-Pan Sicheng-Pan force-pushed the 01-23-_enh_allow_multiple_assignment branch from 6b9e85b to 8209c31 Compare January 24, 2025 02:11
@Sicheng-Pan Sicheng-Pan merged commit 00ce32f into main Jan 24, 2025
81 checks passed
@Sicheng-Pan Sicheng-Pan deleted the 01-23-_enh_allow_multiple_assignment branch February 11, 2025 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants