Skip to content

[ENH] Create database flow e2e #3558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 25, 2025
Merged

[ENH] Create database flow e2e #3558

merged 5 commits into from
Jan 25, 2025

Conversation

sanketkedia
Copy link
Contributor

@sanketkedia sanketkedia commented Jan 24, 2025 •
edited
Loading

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes

  • New functionality

    • end to end create database for rust FE

Test plan

How are these changes tested?

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

None

@github-actions GitHub Actions
Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@sanketkedia Graphite App
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@sanketkedia sanketkedia requested a review from HammadB January 24, 2025 19:24
@sanketkedia sanketkedia marked this pull request as ready for review January 24, 2025 19:24
HammadB
HammadB reviewed Jan 24, 2025
View reviewed changes
rust/frontend/src/lib.rs
let segment_api = SegmentApi::try_from_config(&config)
.await
.expect("Error creating SegmentApi from config");
let server = FrontendServer::new(segment_api);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: we'll probably want to do the tokio spawn and join handle pattern so we can handle sigterm gracefully.

HammadB
HammadB reviewed Jan 24, 2025
View reviewed changes
rust/frontend/src/api.rs Outdated
use crate::config::FrontEndConfig;

#[async_trait::async_trait]
pub trait ServerApi {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be outside of frontend? As bindings also wants to use it. I could go either way now that im writing this.

HammadB
HammadB reviewed Jan 24, 2025
View reviewed changes
HammadB
HammadB reviewed Jan 24, 2025
View reviewed changes
HammadB
HammadB reviewed Jan 24, 2025
View reviewed changes
HammadB
HammadB reviewed Jan 24, 2025
View reviewed changes
HammadB
HammadB reviewed Jan 25, 2025
View reviewed changes
rust/frontend/src/api.rs Outdated
@@ -1,44 +1,24 @@
use chroma_config::Configurable;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit:filename

HammadB
HammadB reviewed Jan 25, 2025
View reviewed changes
rust/frontend/src/server.rs
match res {
Ok(_) => Ok(()),
Err(e) => match e {
CreateDatabaseError::AlreadyExists => Err(StatusCode::CONFLICT),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leave a TODO: we can probably map these to http

@sanketkedia sanketkedia merged commit 5eeba41 into main Jan 25, 2025
79 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HammadB HammadB HammadB left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sanketkedia @HammadB