[BLD]: test Rust stub bindings in CI #3561
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
codetheweb
force-pushed
the
bld-rust-py-bindings-tests
branch
3 times, most recently
from
457585d to
6aa2e0b
Compare
codetheweb
force-pushed
the
bld-rust-py-bindings-tests
branch
from
6aa2e0b to
2a52cfd
Compare
codetheweb
changed the title
codetheweb
commented
Jan 27, 2025
| @@ -107,7 +107,7 @@ def create_collection( | |||
| tenant: str = DEFAULT_TENANT, | |||
| database: str = DEFAULT_DATABASE, | |||
| ) -> CollectionModel: | |||
| return self.proxy_segment_api.create_collection( | |||
| return self.bindings.create_collection( | |||
There was a problem hiding this comment.
I added a stub for this method as admin APIs aren't called by most tests
codetheweb
commented
Jan 27, 2025
| @@ -77,4 +77,28 @@ impl Bindings { | |||
| } | |||
|
|
|||
| ////////////////////////////// Base API ////////////////////////////// | |||
| #[allow(clippy::too_many_arguments)] | |||
| fn create_collection( | |||
There was a problem hiding this comment.
decided to require Python to pass defaults instead of duplicating the defaults here
There was a problem hiding this comment.
note to self: align list databases and others
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Adds basic CI support for testing Rust bindings.
Test plan
How are these changes tested?
pytestfor python,yarn testfor js,cargo testfor rustDocumentation Changes
Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?
n/a