Skip to content

[ENH] Rust<>Python proxy calls back into python #3571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jan 27, 2025
Merged

Conversation

HammadB
Copy link
Collaborator

@HammadB HammadB commented Jan 27, 2025

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • /
  • New functionality
    • Proxies all calls via the bindings back into the python code
    • Some calls are left not going through rust just to make the PR smaller, will stub out the rest, it is functionally the same
    • This is just to allow testing to be green while we convert to the rust based impls

Test plan

How are these changes tested?

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

None

Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

Copy link
Contributor

@codetheweb codetheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think tests will pass without stubbing out the rest of the API, but that's fine, I can do that in my testing PR or we can do it separately

@HammadB
Copy link
Collaborator Author

HammadB commented Jan 27, 2025

All of the methods are stubbed, they proxy back into python, or just never go into rust but still proxy - I don't follow

@codetheweb
Copy link
Contributor

my bad, sorry--misread the implementation
makes sense to me 👍

@HammadB HammadB merged commit 73c30f0 into main Jan 27, 2025
79 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants