Skip to content

[ENH] Add query route #3573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 28, 2025
Merged

[ENH] Add query route #3573

merged 5 commits into from
Jan 28, 2025

Conversation

sanketkedia
Copy link
Contributor

@sanketkedia sanketkedia commented Jan 27, 2025

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes

  • New functionality
    • Add route

Test plan

How are these changes tested?

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

None

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

Copy link

Please tag your PR title with one of: [ENH | BUG | DOC | TST | BLD | PERF | TYP | CLN | CHORE]. See https://docs.trychroma.com/contributing#contributing-code-and-ideas

@sanketkedia sanketkedia changed the title Add query route [ENH] Add query route Jan 27, 2025
@sanketkedia sanketkedia marked this pull request as ready for review January 27, 2025 21:00
Copy link
Contributor

@Sicheng-Pan Sicheng-Pan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@sanketkedia sanketkedia force-pushed the 01-27-add_query_route branch from 86adf8e to fd398ae Compare January 27, 2025 22:05
@Sicheng-Pan Sicheng-Pan force-pushed the 01-27-add_query_route branch from 06ff774 to b76d491 Compare January 28, 2025 00:00
@Sicheng-Pan Sicheng-Pan force-pushed the 01-27-add_query_route branch from b76d491 to 61a5903 Compare January 28, 2025 00:00
@Sicheng-Pan Sicheng-Pan merged commit d397589 into main Jan 28, 2025
89 checks passed
@Sicheng-Pan Sicheng-Pan deleted the 01-27-add_query_route branch February 11, 2025 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants