[ENH] Multi-dimensional admission control. #3579
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
codetheweb
approved these changes
Jan 28, 2025
rust/mdac/src/scorecard.rs
Outdated
| rules: Vec<Rule>, | ||
| estimate_thread_count: usize, | ||
| ) -> Self { | ||
| assert!(estimate_thread_count > 0); |
rust/mdac/src/scorecard.rs
Outdated
| #[test] | ||
| fn basics() { | ||
| let metrics = TestMetrics::default(); | ||
| // NOTE(rescrv): We diverge from the upstream behavior here. If a tag doesn't match a |
There was a problem hiding this comment.
can we clarify what upstream is please
rust/frontend/frontend_config.yaml
Outdated
| request_timeout_ms: 60000 | ||
| circuit_breaker: | ||
| requests: 1 |
There was a problem hiding this comment.
should the default be higher?
There was a problem hiding this comment.
I've removed the default to make it not enabled by default.
rust/frontend/src/frontend.rs
Outdated
| } | ||
|
|
||
| impl Frontend { | ||
| pub fn new(sysdb_client: Box<sysdb::SysDb>) -> Self { | ||
| let scorecard_enabled = Arc::new(AtomicBool::new(false)); | ||
| let scorecard = Arc::new(Scorecard::new(&(), vec![], 128)); |
There was a problem hiding this comment.
should the thread count be provided by config or inferred from the env?
There was a problem hiding this comment.
128 is sufficient for everything we need. I think inferring it would do us strictly worse if we get it wrong as it's an upper bound.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates a multi-dimensional "scorecard" that tags traffic and a circuit breaker that rejects excess traffic.