Skip to content

[ENH] Add cache for FE with no invalidation #3587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 28, 2025
Merged

[ENH] Add cache for FE with no invalidation #3587

merged 2 commits into from
Jan 28, 2025

Conversation

sanketkedia
Copy link
Contributor

@sanketkedia sanketkedia commented Jan 28, 2025 •
edited
Loading

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • ...
  • New functionality
    • FE has in-memory foyer cache

Test plan

How are these changes tested?

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

None

@github-actions GitHub Actions
Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@sanketkedia sanketkedia mentioned this pull request Jan 28, 2025
Merged
1 task
@sanketkedia Graphite App
Copy link
Contributor Author

sanketkedia commented Jan 28, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@sanketkedia sanketkedia marked this pull request as ready for review January 28, 2025 21:13
HammadB
HammadB reviewed Jan 28, 2025
View reviewed changes
rust/cache/src/foyer.rs
@@ -539,3 +540,9 @@ where
V: Clone + Send + Sync + Weighted + StorageValue + 'static,
{
}

impl crate::Weighted for CollectionAndSegments {
fn weight(&self) -> usize {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should default this to 1 tbh

HammadB
HammadB reviewed Jan 28, 2025
View reviewed changes
rust/frontend/src/frontend.rs
.await
.map_err(|_| QueryError::CollectionSegments)?;
.map_err(|_| QueryError::CollectionSegments)?
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this error name seems hard to understand

rescrv
rescrv approved these changes Jan 28, 2025
View reviewed changes
HammadB
HammadB approved these changes Jan 28, 2025
View reviewed changes
Copy link
Collaborator

@HammadB HammadB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

Would prefer if we rename cache_config to be concrete type, encapsulate cache, and see if we can expose fetch()

@sanketkedia sanketkedia mentioned this pull request Jan 28, 2025
Closed
1 task
@sanketkedia sanketkedia force-pushed the 01-28-_enh_add_cache_for_fe_with_no_invalidation branch from 6d090e3 to 9cc5635 Compare January 28, 2025 23:09
@sanketkedia sanketkedia changed the base branch from 01-28-add_parsers to graphite-base/3587 January 28, 2025 23:39
@sanketkedia sanketkedia force-pushed the 01-28-_enh_add_cache_for_fe_with_no_invalidation branch from 9cc5635 to 67f19fe Compare January 28, 2025 23:40
@sanketkedia sanketkedia changed the base branch from graphite-base/3587 to main January 28, 2025 23:40
@sanketkedia sanketkedia force-pushed the 01-28-_enh_add_cache_for_fe_with_no_invalidation branch from 67f19fe to 4759cfd Compare January 28, 2025 23:40
@sanketkedia sanketkedia merged commit 6d4075e into main Jan 28, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rescrv rescrv rescrv approved these changes

@HammadB HammadB HammadB approved these changes

@Sicheng-Pan Sicheng-Pan Awaiting requested review from Sicheng-Pan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sanketkedia @rescrv @HammadB