[TST]: add basic tests for where parsing #3593
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
1 task
codetheweb
commented
Jan 29, 2025
| @@ -52,7 +52,7 @@ pub fn parse_where_document(json_payload: &Value) -> Result<Where, ValidationErr | |||
| let operator_type; | |||
| if key == "$contains" { | |||
| operator_type = DocumentOperator::Contains; | |||
| } else if key == "not_contains" { | |||
| } else if key == "$not_contains" { | |||
codetheweb
force-pushed
the
cln-split-off-where-parsing
branch
from
374573b to
f1b5391
Compare
codetheweb
force-pushed
the
tst-where-parsing
branch
from
63e2f47 to
81c8470
Compare
sanketkedia
approved these changes
Jan 29, 2025
codetheweb
force-pushed
the
cln-split-off-where-parsing
branch
from
f1b5391 to
6079402
Compare
codetheweb
force-pushed
the
tst-where-parsing
branch
from
81c8470 to
db8d330
Compare
codetheweb
changed the base branch from
cln-split-off-where-parsing
to
graphite-base/3593
codetheweb
force-pushed
the
tst-where-parsing
branch
from
db8d330 to
0e2499f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Adds some basic tests for where document and where clause parsing.
Test plan
How are these changes tested?
pytestfor python,yarn testfor js,cargo testfor rustDocumentation Changes
Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?
n/a