Skip to content

[ENH] Plumb ML into fe #3595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 29, 2025
Merged

[ENH] Plumb ML into fe #3595

merged 3 commits into from
Jan 29, 2025

Conversation

HammadB
Copy link
Collaborator

@HammadB HammadB commented Jan 29, 2025 •
edited
Loading

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • Add clone to a bunch of config structs since we need it
  • New functionality
    • Adds a ClientManager to respond to the memberlist changes and update nodes
    • Introduces config for the executor num_connections, and timeouts
    • Performs top-k HWRH for assignment to query nodes and randomly load balances between them
    • Add assign many behavior into assignment policy

Test plan

How are these changes tested?
Not well. Will add in future PR. Manually verified the connection pooling to query nodes

signal-2025-01-29-075332_002

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

None

@github-actions GitHub Actions
Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@github-actions GitHub Actions
Copy link

Please tag your PR title with one of: [ENH | BUG | DOC | TST | BLD | PERF | TYP | CLN | CHORE]. See https://docs.trychroma.com/contributing#contributing-code-and-ideas

@HammadB Graphite App
Copy link
Collaborator Author

HammadB commented Jan 29, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@HammadB HammadB mentioned this pull request Jan 29, 2025
Merged
1 task
@HammadB HammadB force-pushed the hammad/memberlist_fe branch from 99b36a6 to 373ae47 Compare January 29, 2025 04:17
@github-actions GitHub Actions
Copy link

Please tag your PR title with one of: [ENH | BUG | DOC | TST | BLD | PERF | TYP | CLN | CHORE]. See https://docs.trychroma.com/contributing#contributing-code-and-ideas

@HammadB HammadB changed the title plumb ml into fe [ENH] Plumb ML into fe Jan 29, 2025
@HammadB HammadB changed the base branch from hammad/memberlist_fe to main January 29, 2025 04:21
HammadB
HammadB commented Jan 29, 2025
View reviewed changes
rust/frontend/Cargo.toml
thiserror = { workspace = true }
parking_lot = { workspace = true }
rand = { workspace = true }
tower = { version = "0.4.13", features = ["discover"] }
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is so that our tower == tonics

HammadB
HammadB commented Jan 29, 2025
View reviewed changes
rust/frontend/src/config.rs
use chroma_cache::CacheConfig;
use chroma_log::config::LogConfig;
use chroma_sysdb::SysDbConfig;
use figment::providers::{Env, Format, Yaml};
use mdac::CircuitBreakerConfig;
use serde::Deserialize;

#[derive(Deserialize)]
#[derive(Deserialize, Clone)]
pub(super) struct FrontendConfig {
Copy link
Collaborator Author

@HammadB HammadB Jan 29, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO (out of this PR): align on pub(super) reorder nested config vs inline

@HammadB HammadB merged commit d1bde0f into main Jan 29, 2025
89 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@HammadB