[ENH] More routes in rust FE #3609
Conversation
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
Sicheng-Pan
force-pushed
the
01-29-_enh_more_routes_in_rust_fe
branch
from
a52abbd to
5cf14ee
Compare
| @@ -103,6 +106,39 @@ impl Frontend { | |||
| } | |||
| } | |||
|
|
|||
| pub async fn reset(&mut self) -> Result<(), ResetError> { | |||
There was a problem hiding this comment.
nit: I think we need to make this not do anything in non-test env. Otherwise we are giving users a hammer
There was a problem hiding this comment.
I might suggest no-oping it or doing whatever error we do in python when its disabled rn
There was a problem hiding this comment.
No-oped this endpoint
| self.collections_with_segments_cache | ||
| .clear() | ||
| .await | ||
| .map_err(|_| ResetError::Cache) |
There was a problem hiding this comment.
shouldn't this reset the log and the sysdb?
There was a problem hiding this comment.
I assume the log and sysdb doesn't really keep any states (i.e. they should be a thin client). For now I no-oped the endpoint according to the suggestion above
rust/frontend/src/server.rs
Outdated
| } | ||
|
|
||
| async fn version() -> &'static str { | ||
| "0.7.0-dev" |
There was a problem hiding this comment.
should this pull from Cargo.toml
Sicheng-Pan
force-pushed
the
01-29-_enh_more_routes_in_rust_fe
branch
from
2f22758 to
7f03d2c
Compare
Description of changes
Summarize the changes made by this PR.
Test plan
How are these changes tested?
pytestfor python,yarn testfor js,cargo testfor rustDocumentation Changes
Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?