Skip to content

[ENH] Dedup get_collections_with_segments sysdb rpc #3612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

sanketkedia
Copy link
Contributor

@sanketkedia sanketkedia commented Jan 30, 2025

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • Uses partitioned mutex to avoid thundering herd on the sysdb
  • New functionality
    • ...

Test plan

How are these changes tested?

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

None

Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

Copy link
Contributor Author

sanketkedia commented Jan 30, 2025

@sanketkedia sanketkedia requested review from HammadB and rescrv January 30, 2025 01:05
@sanketkedia sanketkedia marked this pull request as ready for review January 30, 2025 01:06
@sanketkedia sanketkedia force-pushed the 01-29-_enh_dedup_get_collections_with_segments_sysdb_rpc branch from 8396d42 to 54819c5 Compare January 30, 2025 02:39
@sanketkedia sanketkedia changed the base branch from 01-29-partitioned_mutex_hnsw_load_uses_this_mutex to graphite-base/3612 January 30, 2025 03:41
@sanketkedia sanketkedia force-pushed the 01-29-_enh_dedup_get_collections_with_segments_sysdb_rpc branch from 2ad3350 to 7381375 Compare January 30, 2025 03:41
@sanketkedia sanketkedia changed the base branch from graphite-base/3612 to main January 30, 2025 03:41
@sanketkedia sanketkedia force-pushed the 01-29-_enh_dedup_get_collections_with_segments_sysdb_rpc branch from 7381375 to 3a4df45 Compare January 30, 2025 03:41
@sanketkedia sanketkedia merged commit 1260c4a into main Jan 30, 2025
88 of 89 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants