Skip to content

[BUG]: Fix foyer lodc buffer splitter bug by bumping version #4107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 17, 2025

Conversation

MrCroxx
Copy link
Contributor

@MrCroxx MrCroxx commented Mar 28, 2025

Description of changes

Summarize the changes made by this PR.

Test plan

How are these changes tested?

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?

Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@HammadB HammadB self-requested a review March 28, 2025 16:06
@HammadB HammadB enabled auto-merge (squash) April 2, 2025 20:02
@sanketkedia
Copy link
Contributor

Waiting for tests to pass. Will merge once CI is green

@MrCroxx
Copy link
Contributor Author

MrCroxx commented Apr 17, 2025

Waiting for tests to pass. Will merge once CI is green

Thank you, @sanketkedia . I found that some tests are not stable. And after I bumped my code, I cannot trigger the CI without your approval. May I ask if there is a better way to handle this? I don't want to waste your time with approvals every time. 🙏

@MrCroxx
Copy link
Contributor Author

MrCroxx commented Apr 17, 2025

image

I found this error in the recent CI pipelines. Did I break something in this PR accidentally?

@sanketkedia
Copy link
Contributor

sanketkedia commented Apr 17, 2025

May I ask if there is a better way to handle this? I don't want to waste your time with approvals every time.

Unfortunately there isn't a better way rn. Will check internally if something can be done about it

@HammadB HammadB disabled auto-merge April 17, 2025 14:35
@HammadB
Copy link
Collaborator

HammadB commented Apr 17, 2025

The test failures here are in a datadog api key fetch, we can merge this.

@HammadB HammadB merged commit 8e82b72 into chroma-core:main Apr 17, 2025
65 of 68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants