Skip to content

[ENH]: set up rendezvous hashing for collection -> garbage collector node mapping #4113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Apr 11, 2025

Conversation

codetheweb
Copy link
Contributor

@codetheweb codetheweb commented Mar 28, 2025

Description of changes

Sets up rendezvous hashing for collections on the garbage collector service similar to the compaction and query services.

Test plan

How are these changes tested?

Tested by creating several collections and observing that they were correctly load balanced across 2 replicas.

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?

n/a

Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

Copy link

github-actions bot commented Apr 9, 2025

✅ The Helm chart's version was changed. Your changes to the chart will be published upon merge to main.

@codetheweb codetheweb force-pushed the feat-gc-collection-node-assignment branch from b561a27 to ee275f3 Compare April 10, 2025 23:51
@codetheweb codetheweb marked this pull request as ready for review April 11, 2025 00:13
@codetheweb codetheweb requested a review from HammadB April 11, 2025 00:13
- get
- list
- watch
# TODO: FIX THIS LEAKY PERMISSION
Copy link
Contributor

@Sicheng-Pan Sicheng-Pan Apr 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this planned for future?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to be honest, I'm not sure exactly what this is referencing
it was from the memberlist template that I copied this from

@codetheweb codetheweb merged commit 566527f into main Apr 11, 2025
66 checks passed
@codetheweb codetheweb deleted the feat-gc-collection-node-assignment branch April 11, 2025 17:20
@codetheweb codetheweb restored the feat-gc-collection-node-assignment branch April 11, 2025 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants