-
Notifications
You must be signed in to change notification settings - Fork 1.6k
[ENH]: set up rendezvous hashing for collection -> garbage collector node mapping #4113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
✅ The Helm chart's version was changed. Your changes to the chart will be published upon merge to |
b561a27
to
ee275f3
Compare
- get | ||
- list | ||
- watch | ||
# TODO: FIX THIS LEAKY PERMISSION |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this planned for future?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to be honest, I'm not sure exactly what this is referencing
it was from the memberlist template that I copied this from
Description of changes
Sets up rendezvous hashing for collections on the garbage collector service similar to the compaction and query services.
Test plan
How are these changes tested?
Tested by creating several collections and observing that they were correctly load balanced across 2 replicas.
Documentation Changes
Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?
n/a