Skip to content

[ENH] When recovering a wal3 manifest, mark it dirty. #4119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 10, 2025
Merged

[ENH] When recovering a wal3 manifest, mark it dirty. #4119

merged 2 commits into from
Apr 10, 2025

Conversation

rescrv
Copy link
Contributor

@rescrv rescrv commented Mar 31, 2025 •
edited
Loading

There was a write hole where recovery would fail to write the dirty bit. Plug it.

@github-actions GitHub Actions
Copy link

Please tag your PR title with one of: [ENH | BUG | DOC | TST | BLD | PERF | TYP | CLN | CHORE]. See https://docs.trychroma.com/contributing#contributing-code-and-ideas

@github-actions GitHub Actions
Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@rescrv rescrv changed the base branch from main to rescrv/wal3-recursive-snapshot March 31, 2025 20:20
@rescrv rescrv changed the title rescrv/wal3 dirty recovery [ENH] When recovering a wal3 manifest, mark it dirty. Mar 31, 2025
@rescrv rescrv requested review from HammadB and sanketkedia March 31, 2025 20:21
@rescrv
[ENH] Make snapshot be recursive.
0033895 
Before this PR, the status quo was to stop at a depth of 2.  This allows
for a small-ish log.  With this change, the snapshots can be of
arbitrary depth, although in practice they will be log(n)/log(1846)
levels deep.
@rescrv rescrv force-pushed the rescrv/wal3-recursive-snapshot branch from fae1096 to 0033895 Compare April 4, 2025 12:31
@rescrv rescrv force-pushed the rescrv/wal3-dirty-recovery branch from e44beec to 1a2dcf0 Compare April 4, 2025 12:32
Base automatically changed from rescrv/wal3-recursive-snapshot to main April 10, 2025 19:29
@rescrv rescrv merged commit 02dd03b into main Apr 10, 2025
83 checks passed
@rescrv rescrv deleted the rescrv/wal3-dirty-recovery branch April 10, 2025 19:29
@adityamaru adityamaru mentioned this pull request Apr 17, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HammadB HammadB HammadB approved these changes

@sanketkedia sanketkedia Awaiting requested review from sanketkedia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rescrv @HammadB