[ENH] Add attributes for frontend metrics #4168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
jasonvigil
force-pushed
the
jason/add-frontend-metrics-attributes
branch
from
426fc01 to
84676f6
Compare
Record tenant, database, and collection_id (where appropriate) attributes for the various frontend endpoints. This will allow us to perform usage queries such as gets per tenant (as well as per database / collection).
jasonvigil
force-pushed
the
jason/add-frontend-metrics-attributes
branch
from
84676f6 to
da1a148
Compare
philipkiely-baseten
pushed a commit
to philipkiely-baseten/chroma
that referenced
this pull request
Apr 8, 2025
## Description of changes Record tenant, database, and collection_id (where appropriate) attributes for the various frontend endpoints. This will allow us to perform usage queries such as gets per tenant (as well as per database / collection). ## Test plan These changes are not tested (yet). The plan is to merge into staging, then manually create some honeycomb dashboards / graphs to verify these attributes are being passed as expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Record tenant, database, and collection_id (where appropriate) attributes for the various frontend endpoints. This will allow us to perform usage queries such as gets per tenant (as well as per database / collection).
Test plan
These changes are not tested (yet). The plan is to merge into staging, then manually create some honeycomb dashboards / graphs to verify these attributes are being passed as expected.