[ENH]: add metrics for garbage collection #4173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 4, 2025
1 task
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
codetheweb
force-pushed
the
feat-gc-manual-e2e-test-fixes
branch
from
628e81f to
d3850af
Compare
codetheweb
force-pushed
the
feat-gc-metrics
branch
from
e6cfdf0 to
5128786
Compare
codetheweb
force-pushed
the
feat-gc-manual-e2e-test-fixes
branch
from
d3850af to
8053f73
Compare
codetheweb
force-pushed
the
feat-gc-metrics
branch
from
5128786 to
eac8577
Compare
codetheweb
force-pushed
the
feat-gc-manual-e2e-test-fixes
branch
2 times, most recently
from
928480d to
c1d52de
Compare
codetheweb
force-pushed
the
feat-gc-metrics
branch
from
eac8577 to
6e97848
Compare
Sicheng-Pan
approved these changes
Apr 7, 2025
codetheweb
changed the base branch from
feat-gc-manual-e2e-test-fixes
to
graphite-base/4173
codetheweb
force-pushed
the
feat-gc-metrics
branch
from
6e97848 to
8f22845
Compare
codetheweb
force-pushed
the
graphite-base/4173
branch
from
c1d52de to
16a5dbc
Compare
codetheweb
force-pushed
the
feat-gc-metrics
branch
from
8f22845 to
30d95b8
Compare
codetheweb
force-pushed
the
feat-gc-metrics
branch
from
30d95b8 to
421de67
Compare
Merge activity
|
philipkiely-baseten
pushed a commit
to philipkiely-baseten/chroma
that referenced
this pull request
Apr 8, 2025
## Description of changes Adds 3 metrics to the garbage collection service as a starting point: - total jobs, segmented by success/failure - job duration in milliseconds (histogram) - total # of files deleted - total # of versions deleted ## Test plan *How are these changes tested?* Ran garbage collection and validated that the produced values in Granfana looked reasonable. ## Documentation Changes *Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the [docs repository](https://github.com/chroma-core/docs)?* n/a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Adds 3 metrics to the garbage collection service as a starting point:
Test plan
How are these changes tested?
Ran garbage collection and validated that the produced values in Granfana looked reasonable.
Documentation Changes
Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?
n/a