Skip to content

[ENH] Use server side token verification for cli login #4185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 8, 2025
Merged

[ENH] Use server side token verification for cli login #4185

merged 2 commits into from
Apr 8, 2025

Conversation

itaismith
Copy link
Contributor

Description of changes

Use server side authentication for CLI login. Instead of having the browser send session data to the CLI.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 7, 2025

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@itaismith itaismith requested a review from codetheweb April 7, 2025 23:20
@itaismith itaismith merged commit c85f6bb into main Apr 8, 2025
83 checks passed
philipkiely-baseten pushed a commit to philipkiely-baseten/chroma that referenced this pull request Apr 8, 2025
@itaismith @philipkiely-baseten
[ENH] Use server side token verification for cli login (chroma-core#4185
bfdefcb 
)

## Description of changes

Use server side authentication for CLI login. Instead of having the
browser send session data to the CLI.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codetheweb codetheweb codetheweb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@itaismith @codetheweb