[ENH]: fix sysdb S3 config for parity between local dev & deployed env, add necessary params #4202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…v, add necessary params
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
|
|
codetheweb
force-pushed
the
fix-sysdb-s3-config
branch
from
5e11444 to
bb45683
Compare
Sicheng-Pan
approved these changes
Apr 7, 2025
philipkiely-baseten
pushed a commit
to philipkiely-baseten/chroma
that referenced
this pull request
Apr 8, 2025
…v, add necessary params (chroma-core#4202) ## Description of changes Updates sysdb S3 config flags to improve parity between local dev and deployed envs. Also adds parameters necessary for configuration in deployed env (bucket name) and verifies that bucket is accessible before continuing startup. ## Test plan *How are these changes tested?* - [x] Tests pass locally with `pytest` for python, `yarn test` for js, `cargo test` for rust ## Documentation Changes *Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the [docs repository](https://github.com/chroma-core/docs)?* n/a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Updates sysdb S3 config flags to improve parity between local dev and deployed envs. Also adds parameters necessary for configuration in deployed env (bucket name) and verifies that bucket is accessible before continuing startup.
Test plan
How are these changes tested?
pytestfor python,yarn testfor js,cargo testfor rustDocumentation Changes
Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?
n/a