Skip to content

[TST]: sysdb should create S3 bucket if it doesn't exist when starting via Tilt #4207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 8, 2025
Merged

[TST]: sysdb should create S3 bucket if it doesn't exist when starting via Tilt #4207

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cb228f1
[TST]: sysdb should create S3 bucket if it doesn't exist when startin…
codetheweb Apr 7, 2025
e9a4111
Merge branch 'main' into fix-sysdb-create-bucket-if-not-exists-tilt
codetheweb Apr 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions go/cmd/coordinator/cmd.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ func init() {
Cmd.Flags().StringVar(&conf.CompactionServicePodLabel, "compaction-pod-label", "compaction-service", "Compaction pod label")

// S3 config
Cmd.Flags().BoolVar(&conf.MetaStoreConfig.CreateBucketIfNotExists, "create-bucket-if-not-exists", false, "Create bucket if not exists")
Cmd.Flags().StringVar(&conf.MetaStoreConfig.BucketName, "bucket-name", "chroma-storage", "Bucket name")
Cmd.Flags().StringVar(&conf.MetaStoreConfig.Region, "s3-region", "us-east-1", "Region")
Cmd.Flags().StringVar(&conf.MetaStoreConfig.Endpoint, "s3-endpoint", "", "S3 endpoint")
Expand Down
1 change: 1 addition & 0 deletions k8s/distributed-chroma/values.dev.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ sysdb:
s3-access-key-id: "minio"
s3-secret-access-key: "minio123"
s3-force-path-style: true
create-bucket-if-not-exists: true
rustFrontendService:
# We have to specify the command, because the Dockerfile uses the CLI since its shared with
# single node, so in values.dev we pass the CONFIG_PATH into the chroma run command
Expand Down
Loading