Skip to content

[BLD]: remove rustup self update in CI #4221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 8, 2025

Conversation

codetheweb
Copy link
Contributor

@codetheweb codetheweb commented Apr 8, 2025

Description of changes

Depot runner images now ship with a new enough version of rustup for rust-toolchain.toml to work properly.

Copy link

github-actions bot commented Apr 8, 2025

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

Copy link
Contributor Author

codetheweb commented Apr 8, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codetheweb codetheweb marked this pull request as ready for review April 8, 2025 16:53
@codetheweb codetheweb force-pushed the bld-bump-rust-sccache-action branch from ca36173 to 1e663e8 Compare April 8, 2025 17:09
@codetheweb codetheweb force-pushed the bld-remove-rustup-update-in-ci branch from daf8882 to f283ba2 Compare April 8, 2025 17:09
@codetheweb codetheweb changed the base branch from bld-bump-rust-sccache-action to graphite-base/4221 April 8, 2025 17:22
@codetheweb codetheweb force-pushed the graphite-base/4221 branch from 1e663e8 to fcef43b Compare April 8, 2025 17:22
@codetheweb codetheweb force-pushed the bld-remove-rustup-update-in-ci branch from f283ba2 to 7874eb6 Compare April 8, 2025 17:22
@graphite-app graphite-app bot changed the base branch from graphite-base/4221 to main April 8, 2025 17:23
@codetheweb codetheweb force-pushed the bld-remove-rustup-update-in-ci branch from 7874eb6 to 2b79efd Compare April 8, 2025 17:23
@codetheweb codetheweb enabled auto-merge (squash) April 8, 2025 18:24
@codetheweb codetheweb merged commit 2a10ea3 into main Apr 8, 2025
83 checks passed
@codetheweb codetheweb deleted the bld-remove-rustup-update-in-ci branch April 8, 2025 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant