[BUG]: remove leading slash from version file name

[codetheweb]

Description of changes

Minio and S3 treat leading in keys differently. Minio strips the leading slash, S3 does not. This means that attempting to look up the key /foo for s3://sample-bucket/foo fails, but succeeds when testing locally with Minio.

This materializes as the garbage collector being unable to fetch version files in staging.

I will update the collections.version_file_name column in staging after merge to manually remove the leading slash.

Test plan

How are these changes tested?

I connected to the Postgres sysdb in my local environment and verified that version file names are now saved without a slash prefix.

[github-actions]

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

• Can you think of any use case in which the code does not behave as intended? Have they been tested?
• Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
• If appropriate, are there adequate property based tests?
• If appropriate, are there adequate unit tests?
• Should any logging, debugging, tracing information be added or removed?
• Are error messages user-friendly?
• Have all documentation changes needed been made?
• Have all non-obvious changes been commented?

System Compatibility

• Are there any potential impacts on other parts of the system or backward compatibility?
• Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

• Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)