Skip to content

[BUG]: use absolute cutoff time when listing collections to garbage collect #4245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

codetheweb
Copy link
Contributor

@codetheweb codetheweb commented Apr 9, 2025

Description of changes

We currently send a relative cutoff time in seconds to the Sysdb when it expects an absolute cutoff time. This updates the garbage collection service to send an absolute cutoff time instead.

Test plan

How are these changes tested?

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?

n/a

Copy link

github-actions bot commented Apr 9, 2025

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@@ -408,7 +409,7 @@ message ListCollectionsToGcRequest {
// before this cutoff time.
// SysDb can apply additional logic to return the collections that should
// be prioritized for GC.
optional uint64 cutoff_time_secs = 1;
optional google.protobuf.Timestamp cutoff_time = 1;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't care about backwards compatibility
(I figured a timestamp type works better as a way of explicitly communicating that this is an absolute timestamp)

@codetheweb codetheweb marked this pull request as ready for review April 9, 2025 17:41
@codetheweb codetheweb requested a review from Sicheng-Pan April 9, 2025 17:41
@codetheweb codetheweb force-pushed the bug-use-absolute-cutoff-time-when-listing-collections-to-gc branch from d2ba895 to 1f8bc52 Compare April 9, 2025 17:48
@codetheweb codetheweb enabled auto-merge (squash) April 9, 2025 17:48
@codetheweb codetheweb merged commit 77f4d01 into main Apr 9, 2025
82 checks passed
@codetheweb codetheweb deleted the bug-use-absolute-cutoff-time-when-listing-collections-to-gc branch April 9, 2025 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants