[ENH] Gracefully shutdown GC system #4246
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
Sicheng-Pan
commented
Apr 9, 2025
Comment on lines
+182
to
+185
| fn on_stop_timeout(&self) -> Duration { | ||
| // NOTE: Increased timeout for remaining jobs to finish | ||
| Duration::from_secs(60) | ||
| } |
There was a problem hiding this comment.
Question: should we make this configurable?
There was a problem hiding this comment.
yes, but ok doing that as a follow-up
codetheweb
approved these changes
Apr 9, 2025
Comment on lines
+182
to
+185
| fn on_stop_timeout(&self) -> Duration { | ||
| // NOTE: Increased timeout for remaining jobs to finish | ||
| Duration::from_secs(60) | ||
| } |
There was a problem hiding this comment.
yes, but ok doing that as a follow-up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Summarize the changes made by this PR.
system.stop()to gracefully shutdown all components when SIGINT/SIGTERM is received. Notice that the system component will always be shutdown once the existing message has been handled, so we don't need to worry about partial progress in the GC job.Test plan
How are these changes tested?
pytestfor python,yarn testfor js,cargo testfor rustDocumentation Changes
Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?