Skip to content

[ENH]: allow overriding metrics endpoint with standard OTEL_EXPORTER_OTLP_METRICS_ENDPOINT if set #4248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 9, 2025

Conversation

codetheweb
Copy link
Contributor

@codetheweb codetheweb commented Apr 9, 2025

Description of changes

OTEL_EXPORTER_OTLP_METRICS_ENDPOINT is a standard environment variable used by OTLP SDKs. This updates our metric exporter set up so that this value is properly consumed if set.

Test plan

How are these changes tested?

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?

n/a

Copy link

github-actions bot commented Apr 9, 2025

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@codetheweb codetheweb changed the title [ENH]: allow overriding metrics endpoint with standard OTEL_EXPORTER_OTLP_METRICS_ENDPOINT if set [ENH]: allow overriding metrics endpoint with standard OTEL_EXPORTER_OTLP_METRICS_ENDPOINT if set Apr 9, 2025
@codetheweb codetheweb marked this pull request as ready for review April 9, 2025 19:55
@codetheweb codetheweb requested a review from Sicheng-Pan April 9, 2025 20:01
@codetheweb codetheweb enabled auto-merge (squash) April 9, 2025 20:07
@Sicheng-Pan
Copy link
Contributor

Note: we could add a new config field in our config file for this, but would prefer to stick to standard otel env var for now

@codetheweb codetheweb merged commit a1266cc into main Apr 9, 2025
67 checks passed
@codetheweb codetheweb deleted the feat-read-metrics-endpoint-env-var-if-set branch April 9, 2025 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants