Skip to content

[CHORE]: Local compation manager error propagation for sqlite #4258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 21, 2025
Merged

[CHORE]: Local compation manager error propagation for sqlite #4258

merged 2 commits into from
Apr 21, 2025

Conversation

tazarov
Copy link
Contributor

@tazarov tazarov commented Apr 10, 2025

Description of changes

Summarize the changes made by this PR.

Test plan

How are these changes tested?

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?

@github-actions GitHub Actions
Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@github-actions GitHub Actions
Copy link

Please tag your PR title with one of: [ENH | BUG | DOC | TST | BLD | PERF | TYP | CLN | CHORE]. See https://docs.trychroma.com/contributing#contributing-code-and-ideas

@tazarov Graphite App
Copy link
Contributor Author

tazarov commented Apr 10, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@tazarov tazarov changed the title chore: Local compation manager error propagation for sqlite [CHORE]: Local compation manager error propagation for sqlite Apr 10, 2025
@tazarov tazarov force-pushed the trayan-04-10-chore_local_compation_manager_error_propagation_for_sqlite branch from bb0a6e5 to b2a7985 Compare April 11, 2025 08:38
@tazarov tazarov force-pushed the trayan-04-10-chore_local_compation_manager_error_propagation_for_sqlite branch from b2a7985 to 08ccbdf Compare April 16, 2025 06:30
@tazarov tazarov requested a review from HammadB April 16, 2025 09:26
@tazarov
Copy link
Contributor Author

tazarov commented Apr 16, 2025

@HammadB, tiny but it helps in debugging things.

@HammadB HammadB merged commit aa6375d into main Apr 21, 2025
69 checks passed
warpbuild-benchmark-bot bot added a commit to WarpBuilds/chroma that referenced this pull request Apr 21, 2025
@warpbuild-benchmark-bot
[CHORE]: Local compation manager error propagation for sqlite (chroma…
c603b3f 
…-core#4258)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HammadB HammadB HammadB approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tazarov @HammadB