Skip to content

[CLN] Deprecate delete list file in GC #4266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 11, 2025

Conversation

Sicheng-Pan
Copy link
Contributor

@Sicheng-Pan Sicheng-Pan commented Apr 11, 2025

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • The delete list is no longer used during GC and should be removed
  • New functionality
    • ...

Test plan

How are these changes tested?

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?

Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Sicheng-Pan Sicheng-Pan marked this pull request as ready for review April 11, 2025 00:21
@Sicheng-Pan Sicheng-Pan requested a review from codetheweb April 11, 2025 00:22
@Sicheng-Pan Sicheng-Pan force-pushed the 04-10-_cln_deprecate_delete_list_file_in_gc branch from 586a921 to ac040e7 Compare April 11, 2025 17:16
Copy link
Contributor

@codetheweb codetheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since we no longer have this file for debugging, could we log any non-404 errors?

@Sicheng-Pan Sicheng-Pan force-pushed the 04-10-_cln_deprecate_delete_list_file_in_gc branch from 44514b7 to 84bba6c Compare April 11, 2025 17:40
@Sicheng-Pan Sicheng-Pan merged commit 4548dbb into main Apr 11, 2025
69 checks passed
Copy link
Contributor Author

Merge activity

  • Apr 11, 3:24 PM EDT: A user merged this pull request with Graphite.

@Sicheng-Pan Sicheng-Pan deleted the 04-10-_cln_deprecate_delete_list_file_in_gc branch April 16, 2025 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants