Skip to content

[ENH] Improve backoff and throttling of wal3. #4302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 17, 2025
Merged

Conversation

rescrv
Copy link
Contributor

@rescrv rescrv commented Apr 16, 2025

This does multiple things:

  • Adds a Backoff code to pushlogs and plumbs it upwards.
  • Coalesces the two timeouts that were used in batch_manager and uses
    them everywhere.
  • Stops batching by record count. Byte count only.
  • Adds a backoff condition to the batch manager. If the batch size and
    then some is in the log, it'll set backoff mode to shed further
    writes.
  • Configures the writer in tilt config.
  • Plumbs an error for exp backoff.

Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

rescrv added 3 commits April 17, 2025 09:46
This does multiple things:

- Adds a Backoff code to pushlogs and plumbs it upwards.
- Coalesces the two timeouts that were used in batch_manager and uses
  them everywhere.
- Stops batching by record count.  Byte count only.
- Adds a backoff condition to the batch manager.  If the batch size and
  then some is in the log, it'll set backoff mode to shed further
  writes.
- Configures the writer in tilt config.
@rescrv rescrv force-pushed the rescrv/wal3-batching branch from 3ae9f8c to c61c06f Compare April 17, 2025 16:46
@rescrv rescrv merged commit 55cde3b into main Apr 17, 2025
68 checks passed
@rescrv rescrv deleted the rescrv/wal3-batching branch April 17, 2025 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants