Skip to content

[BUG] Fix an ordering and windowing bug in new log service. #4306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 17, 2025

Conversation

rescrv
Copy link
Contributor

@rescrv rescrv commented Apr 17, 2025

This fixes a critical bug in the as-of-yet-unreleased log service in
which logs would pull incorrectly. The flow of the bug is as follows:

  1. Fetch logs scans to get a Vec.
  2. Fetch all parquet files in parallel.
  3. Take the first batch_size records across all files regardless of
    their start/limit.

rescrv added 4 commits April 17, 2025 09:46
This does multiple things:

- Adds a Backoff code to pushlogs and plumbs it upwards.
- Coalesces the two timeouts that were used in batch_manager and uses
  them everywhere.
- Stops batching by record count.  Byte count only.
- Adds a backoff condition to the batch manager.  If the batch size and
  then some is in the log, it'll set backoff mode to shed further
  writes.
- Configures the writer in tilt config.
This fixes a critical bug in the as-of-yet-unreleased log service in
which logs would pull incorrectly.  The flow of the bug is as follows:

1)  Fetch logs scans to get a Vec<Parquet>.
2)  Fetch all parquet files in parallel.
3)  Take the first batch_size records across all files regardless of
    their start/limit.
Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@rescrv rescrv requested a review from sanketkedia April 17, 2025 16:49
Base automatically changed from rescrv/wal3-batching to main April 17, 2025 17:25
@rescrv rescrv merged commit 55911a2 into main Apr 17, 2025
69 checks passed
@rescrv rescrv deleted the rescrv/ordering-windowing-bug branch April 17, 2025 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants