Skip to content

[ENH] Add user agent to rust frontend traces #4323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 18, 2025

Conversation

jasonvigil
Copy link
Contributor

Description of changes

Adds user agent to rust frontend traces. Previously this was included in the legacy frontend traces, but we had not included it in the rust frontend traces (yet).

Test plan

Tested locally with tilt environment, confirmed traces included user agent in jaeger.

Documentation Changes

n/a

Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@jasonvigil jasonvigil enabled auto-merge (squash) April 18, 2025 20:29
@jasonvigil jasonvigil disabled auto-merge April 18, 2025 20:29
@jasonvigil jasonvigil enabled auto-merge (squash) April 18, 2025 20:30
@jasonvigil jasonvigil merged commit 868ac53 into main Apr 18, 2025
69 checks passed
@jasonvigil jasonvigil deleted the jason/add-user-agent-to-frontend-traces branch April 23, 2025 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants