[BUG]: <100 items, >20% delete Wrong distance comparison in local HNSW

[tazarov]

Fixes: #4275

Description of changes

Summarize the changes made by this PR.

• Improvements & Bug fixes
  • Fixes an issue a logical error in distance comparison when adding RecordDistance to heap. We're looking for minimal no maximal distance
  • When traversing a index with less than 100 items and more than 20% of the data deleted

Test plan

How are these changes tested?

• Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?

[github-actions]

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

• Can you think of any use case in which the code does not behave as intended? Have they been tested?
• Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
• If appropriate, are there adequate property based tests?
• If appropriate, are there adequate unit tests?
• Should any logging, debugging, tracing information be added or removed?
• Are error messages user-friendly?
• Have all documentation changes needed been made?
• Have all non-obvious changes been commented?

System Compatibility

• Are there any potential impacts on other parts of the system or backward compatibility?
• Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

• Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

[tazarov]

• [BUG]: <100 items, >20% delete Wrong distance comparison in local HNSW #4334 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[jeffchuber]

@tazarov seems like possibly a bad bug... can you see what tests we have and why this was not caught?

[Nayjest]

@HammadB @tazarov, could you please let me know the planned release date that will include this fix?

Thanks!