Skip to content

[BUG] Segmentation fault in get_block #4336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 21, 2025
Merged

[BUG] Segmentation fault in get_block #4336

merged 2 commits into from
Apr 21, 2025

Conversation

sanketkedia
Copy link
Contributor

@sanketkedia sanketkedia commented Apr 21, 2025 •
edited
Loading

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • We extend the lifetime of a block reference that is present in the reader's loaded_blocks hashmap and hand out that reference for reads. However if get_block() is called concurrently by multiple actors then they can race and overwrite an existing entry of the hash map. This will invalidate all existing references to that block causing null pointer exceptions and/or segmentation faults
  • New functionality
    • ...

Test plan

How are these changes tested?

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

None

@github-actions GitHub Actions
Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@sanketkedia Graphite App
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@sanketkedia sanketkedia requested a review from HammadB April 21, 2025 17:54
@sanketkedia sanketkedia marked this pull request as ready for review April 21, 2025 17:54
@sanketkedia sanketkedia changed the title [BUG] Null Pointer Exception in get_block [BUG] Segmentation fault in get_block Apr 21, 2025
HammadB
HammadB reviewed Apr 21, 2025
View reviewed changes
rust/blockstore/src/arrow/blockfile.rs
if let Some(block) = write_guard.get(&block_id) {
return Ok(Some(unsafe { transmute::<&Block, &Block>(&**block) }));
}
write_guard.insert(block_id, Box::new(block));
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think ideally block_manager should return a heap-allocated type, that would kill the rc

@sanketkedia sanketkedia merged commit 357c414 into main Apr 21, 2025
69 checks passed
warpbuild-benchmark-bot bot added a commit to WarpBuilds/chroma that referenced this pull request Apr 21, 2025
@warpbuild-benchmark-bot
[BUG] Segmentation fault in get_block (chroma-core#4336)
c7696dd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HammadB HammadB HammadB approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sanketkedia @HammadB