[CHORE] Enable rust log service, set timeouts, change tilt. #4338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
rescrv
force-pushed
the
rescrv/reenable-log
branch
from
bff3db2 to
3b21d80
Compare
It flakes rarely, but compaction logs show the last thing before tilt gets torn down is the compaction still making progress. Give it 60 more seconds.
sanketkedia
reviewed
Apr 22, 2025
| @@ -108,6 +108,8 @@ def count(collection: Collection, record_set: RecordSet) -> None: | |||
| """The given collection count is equal to the number of embeddings""" | |||
| count = collection.count() | |||
| normalized_record_set = wrap_all(record_set) | |||
| if count != len(normalized_record_set["ids"]): | |||
| print('count mismatch:', count, '=!', len(normalized_record_set["ids"])) | |||
| assert count == len(normalized_record_set["ids"]) | |||
There was a problem hiding this comment.
nit: won't the assert report both the expected and obtained counts? why the print?
There was a problem hiding this comment.
Because X == Y evaluates to a bool, so assert cannot see the values.
There was a problem hiding this comment.
assert a == b, '%s != %s' % (a, b)
sanketkedia
reviewed
Apr 22, 2025
| @@ -61,6 +61,11 @@ impl RootConfig { | |||
| pub fn load_from_path(path: &str) -> Self { | |||
| // Unfortunately, figment doesn't support environment variables with underscores. So we have to map and replace them. | |||
| // Excluding our own environment variables, which are prefixed with CHROMA_. | |||
| eprintln!("loading config from {path}"); | |||
There was a problem hiding this comment.
nit: why eprintln? Is it because tracing is not yet inited?
There was a problem hiding this comment.
Before tracing is initialized.
sanketkedia
reviewed
Apr 22, 2025
| @@ -160,6 +160,11 @@ impl FrontendServerConfig { | |||
| } | |||
|
|
|||
| pub fn load_from_path(path: &str) -> Self { | |||
| // SAFETY(rescrv): If we cannot read the config, we panic anyway. | |||
| eprintln!( | |||
There was a problem hiding this comment.
why eprintln? Is it because tracing is not yet inited?
sanketkedia
reviewed
Apr 22, 2025
|
|
||
| executor: | ||
| distributed: | ||
| connections_per_node: 5 | ||
| replication_factor: 2 | ||
| connect_timeout_ms: 5000 | ||
| request_timeout_ms: 5000 | ||
| request_timeout_ms: 60000 # 1 minute |
There was a problem hiding this comment.
Is this because the latency to log is now more than before?
There was a problem hiding this comment.
I changed it because we have a 1min timeout on minio. It doesn't make sense to have that one be so high and this one be low. For CI stability, I chose to up this one.
sanketkedia
approved these changes
Apr 22, 2025
warpbuild-benchmark-bot bot
added a commit
to WarpBuilds/chroma
that referenced
this pull request
Apr 24, 2025
warpbuild-benchmark-bot bot
added a commit
to WarpBuilds/chroma
that referenced
this pull request
Apr 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Test plan
pytestfor python,yarn testfor js,cargo testfor rustDocumentation Changes
N/A