[CLN] Split get orchestrator

[Sicheng-Pan]

Description of changes

Summarize the changes made by this PR.

• Improvements & Bug fixes
  • Renamed the KnnFilterOrchestrator to FilterOrchestrator
  • Seperated the KnnError type into error types for each individual orchestrators
  • Simplify GetOrchestrator to reuse the FilterOrchestrator
• New functionality
  • N/A

Test plan

How are these changes tested?

• Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs section?

[github-actions]

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

• Can you think of any use case in which the code does not behave as intended? Have they been tested?
• Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
• If appropriate, are there adequate property based tests?
• If appropriate, are there adequate unit tests?
• Should any logging, debugging, tracing information be added or removed?
• Are error messages user-friendly?
• Have all documentation changes needed been made?
• Have all non-obvious changes been commented?

System Compatibility

• Are there any potential impacts on other parts of the system or backward compatibility?
• Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

• Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

[Sicheng-Pan]

• [CLN] Split get orchestrator #4673 👈 (View in Graphite)
• [CLN] Unify operator types #4656
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[propel-code-bot]

Refactor and Modularize Orchestration Pipeline: Split, Rename, and Decouple Error Types

This PR significantly refactors the Chroma orchestration subsystem to modularize and clarify the orchestration pipeline. The previously monolithic 'KnnFilterOrchestrator' is renamed to 'FilterOrchestrator', and new orchestrators are introduced to clarify separation of concerns between filtering, KNN (both HNSW and SPANN), and 'Get' operations. Shared error types like 'KnnError' are split into focused error enums for each orchestrator, improving error clarity, code modularity, and maintainability. The 'GetOrchestrator' logic is simplified by delegating the filtering stage to 'FilterOrchestrator', enabling both orchestration code and test/bench code to use unified, more composable primitives. This involved significant changes to Rust modules, orchestrator interfaces, test/bench wiring, and RPC endpoints.

Key Changes:
• Renamed 'KnnFilterOrchestrator' to 'FilterOrchestrator'; removed and split the 'KnnError' type by orchestrator (KnnHnswOrchestratorError, KnnSpannOrchestratorError, etc).
• Split orchestration logic for filtering and vector search: introduced 'FilterOrchestrator', 'KnnHnswOrchestrator', and 'KnnSpannOrchestrator' for separation of filtering, HNSW/Spann KNN search, and projection.
• Refactored 'GetOrchestrator' to depend only on the output of 'FilterOrchestrator', greatly simplifying its pipeline and reducing coupling.
• Propagated orchestrator changes to API/server call points, test code, and all benchmarks, updating calls and type dependencies.
• Removed legacy 'knn' and 'knn_filter' modules; added new 'filter', 'knn_hnsw', and 'knn_spann' modules with orchestrator and error type definitions.
• Updated Protobuf conversion to support possible empty projection results ('Default' impl for GetResult and ProjectionOutput).

Affected Areas:
• rust/worker/src/execution/orchestration (filter.rs, get.rs, knn_hnsw.rs, knn_spann.rs, mod.rs)
• rust/worker/src/server.rs
• rust/types/src/execution/operator.rs
• rust/worker/benches/get.rs
• rust/worker/benches/query.rs
• rust/worker/src/execution/orchestration/compact.rs

This summary was automatically generated by @propel-code-bot