-
Notifications
You must be signed in to change notification settings - Fork 1.7k
[ENH]: Return database id in get collections call from sysdb #4686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH]: Return database id in get collections call from sysdb #4686
Conversation
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Expose Database ID in SysDB This PR adds database ID information to the Rust, Go, and Protobuf representations of a Collection, and ensures that SysDB includes the database ID when returning collection metadata (e.g., through Key Changes: Affected Areas: This summary was automatically generated by @propel-code-bot |
4411701
to
f9a9e60
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
discussed offline - maybe handle b/w compat with Optional on database id on collection
a7a0d89
to
a577316
Compare
## Description of changes _Summarize the changes made by this PR._ - Improvements & Bug fixes - Organizing data of collections in s3 by s3 prefixes requires knowledge about database id in the write path. This PR populates and returns database id from sysdb in get_collections rpc - We skip serializing and returning this from FE to client - Even though the collection model is the same for both local and distributed, we don't set it in local currently. However, it can be done if needed - New functionality - ... ## Test plan _How are these changes tested?_ - [x] Tests pass locally with `pytest` for python, `yarn test` for js, `cargo test` for rust ## Documentation Changes None
This PR cherry-picks the commit 72985bd onto release/2025-06-13. If there are unresolved conflicts, please resolve them manually. Co-authored-by: Sanket Kedia <[email protected]>
Description of changes
Summarize the changes made by this PR.
Test plan
How are these changes tested?
pytest
for python,yarn test
for js,cargo test
for rustDocumentation Changes
None