ciao-controller: check instances in list belong to tenant

tenantServerAction function was acting on instances when a list of
servers was provided, the function now validates that if a servers
list is provided then ensure it belongs to the tenant specified
before proceeding to the action.

Fixes #98

Signed-off-by: Leoswaldo Macias <[email protected]>

Author: Leoswaldo Macias

ciao-controller/compute.go

@@ -953,7 +953,12 @@ func createServer(w http.ResponseWriter, r *http.Request, context *controller) {
 
 type instanceAction func(string) error
 
+// tenantServersAction will apply the operation sent in POST (as os-start, os-stop, os-delete)
+// to all servers of a tenant or if ServersID size is greater than zero it will be applied
+// only to the subset provided that also belongs to the tenant
 func tenantServersAction(w http.ResponseWriter, r *http.Request, context *controller) {
+	vars := mux.Vars(r)
+	tenant := vars["tenant"]
 	var servers payloads.CiaoServersAction
 	var actionFunc instanceAction
 	var statusFilter string
@@ -994,14 +999,22 @@ func tenantServersAction(w http.ResponseWriter, r *http.Request, context *contro
 	}
 
 	if len(servers.ServerIDs) > 0 {
-		/* TODO Check that instance belongs to the right tenant */
-		for _, instance := range servers.ServerIDs {
-			actionFunc(instance)
+		for _, instanceID := range servers.ServerIDs {
+			// make sure the instance belongs to the tenant
+			instance, err := context.ds.GetInstance(instanceID)
+
+			if err != nil {
+				returnErrorCode(w, http.StatusNotFound, "Instance %s could not be found", instanceID)
+				return
+			}
+
+			if instance.TenantID != tenant {
+				returnErrorCode(w, http.StatusNotFound, "Instance %s does not belong to tenant %s", instanceID, tenant)
+				return
+			}
+			actionFunc(instanceID)
 		}
 	} else {
-		vars := mux.Vars(r)
-		tenant := vars["tenant"]
-
 		/* We want to act on all relevant instances */
 		instances, err := context.ds.GetAllInstancesFromTenant(tenant)
 		if err != nil {