This repository was archived by the owner on Jul 16, 2020. It is now read-only.
test-cases: Fix two bugs #314
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
markdryan
commented
Jun 23, 2016
markdryan
commented
- The first commit fixes Test-cases makes it hard to tell why a unit test fails #295. Test-cases now collects the logs of failing tests cases and outputs them to standard err when all tests have been run.
- The second fixes issue, test-cases can hang when packages are specified in a certain order #307, which is a hang that could occur if you specified the packages to test in a certain order.
added 2 commits
June 23, 2016 18:40
Test-cases now gathers up the logs of failed test cases and outputs them after the report. Logs are grouped by unit test so it should be easy to locate the cause of the failure. Also, we only output logs from failed test-cases so these logs are not hidden amongst the logs of those that succeed. Failed logs are currently only output for textual reports. Fixes ciao-project#295 Signed-off-by: Mark Ryan <[email protected]>
The code that computed the root package of all packages under test was buggy. Depending on the order of the packages supplied to test-cases, it was possible to enter an endless loop. This PR fixes the issue. Fixes ciao-project#307 Signed-off-by: Mark Ryan <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.