refactor: Simplify DuckDB export #112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
kevinjqliu
approved these changes
Apr 11, 2025
There was a problem hiding this comment.
LGTM heres the docs for the export database statement in duckdb https://duckdb.org/docs/stable/sql/statements/export.html
|
I'll have this reviewed and merged ASAP thanks for the pull request ! Edit: Reviewed, LGTM. |
clflushopt
approved these changes
Apr 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies the DuckDB export code. There are no noticeable performance changes, the only difference is that the export is accompanied with a
load.sqland a (rather redundant)schema.sqlfile.PS: Thanks for creating and publishing this project, it's GREAT and I'm migrating a lot of my benchmark script to use this instead of DuckDB's built-in
dbgenfunction.