Skip to content

Avoid String creation while loading Distributions (2% less startup time) #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 25, 2025
Merged

Avoid String creation while loading Distributions (2% less startup time) #63

merged 1 commit into from
Mar 25, 2025

Conversation

alamb
Copy link
Collaborator

@alamb alamb commented Mar 25, 2025

This PR avoids copying / creating Strings while loading the inital distributions,

It yields a small but measurable 2% improvement

Timings

time target/release/tpchgen-cli --tables line-item -s 0.001 --output-dir=/tmp/tpchdbgen-rs
branch time
main 0m0.973s
this pr 0m0.952s

@alamb alamb marked this pull request as ready for review March 25, 2025 00:31
clflushopt
clflushopt approved these changes Mar 25, 2025
View reviewed changes
Copy link
Owner

@clflushopt clflushopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; neat !

@clflushopt clflushopt merged commit 0256ca2 into clflushopt:main Mar 25, 2025
6 checks passed
@alamb alamb deleted the alamb/no_strings branch March 25, 2025 10:05
@alamb
Copy link
Collaborator Author

alamb commented Mar 25, 2025

Thanks! Welcome back @clflushopt !

@alamb alamb mentioned this pull request Mar 25, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clflushopt clflushopt clflushopt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alamb @clflushopt