-
Notifications
You must be signed in to change notification settings - Fork 14
Implement arrow conversion for remaining tables #74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@clflushopt I think this is the last PR before I can add real parquet support |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, my comments are non-blocking so feel free to merge ! this seems to have been cumbersone 😅 thanks for taking the initiative !!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for the review @clflushopt
Here we go! On to parquet generation directly |
tpchgen-arrow
crate to generate ArrowRecordBatch
es, implement conversion forLineItem
#71It is mostly a mechanical (but large) PR