Skip to content

Implement arrow conversion for remaining tables #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 28, 2025

Conversation

alamb
Copy link
Collaborator

@alamb alamb commented Mar 27, 2025

  1. Implements table --> Arrow conversion for the remaining TPCH tables
  2. Adds test coverage

It is mostly a mechanical (but large) PR

@alamb alamb force-pushed the alamb/more_arrow branch from ff14101 to b895c61 Compare March 27, 2025 15:16
@alamb alamb marked this pull request as ready for review March 27, 2025 15:18
@alamb alamb requested a review from clflushopt March 27, 2025 15:47
@alamb
Copy link
Collaborator Author

alamb commented Mar 27, 2025

@clflushopt I think this is the last PR before I can add real parquet support

Copy link
Owner

@clflushopt clflushopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, my comments are non-blocking so feel free to merge ! this seems to have been cumbersone 😅 thanks for taking the initiative !!

Copy link
Collaborator Author

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for the review @clflushopt

@alamb
Copy link
Collaborator Author

alamb commented Mar 28, 2025

Here we go! On to parquet generation directly

@alamb alamb merged commit d912ec4 into clflushopt:main Mar 28, 2025
7 checks passed
@alamb alamb deleted the alamb/more_arrow branch March 28, 2025 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants