Do not generate CSV header multiple times #78
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the code was generating a CSV header at the start of the chunk rather than once per file
Let's make it once per file
I tested with
cargo run --release -- --format=csv --tables=part -s 1 --output-dir=/tmp/tpchgen-rs datafusion-cli -c "select * from '/tmp/tpchgen-rs/part.csv'"
Which works great like this:
FYI @niebayes -- thank you for the report and test