During Pages and R2 validations, show sizes in MiB (consistently with the Cloudflare docs) (#4577)

Author: dario-piotrowicz

.changeset/eight-stingrays-tap.md

@@ -0,0 +1,5 @@
+---
+"wrangler": patch
+---
+
+During the R2 validation, show `MAX_UPLOAD_SIZE` errors using MiB (consistently with the Cloudflare docs)

.changeset/itchy-knives-share.md

@@ -0,0 +1,5 @@
+---
+"wrangler": patch
+---
+
+During the Pages validation, show `MAX_UPLOAD_SIZE` errors using MiB (consistently with the Cloudflare docs)

packages/wrangler/src/__tests__/pages/project-validate.test.ts

@@ -35,8 +35,8 @@ describe("project validate", () => {
 
 		await expect(() => runWrangler("pages project validate .")).rejects
 			.toThrowErrorMatchingInlineSnapshot(`
-		"Error: Pages only supports files up to 1.05 MB in size
-		logo.png is 1.05 MB in size"
+		"Error: Pages only supports files up to 1 MiB in size
+		logo.png is 1 MiB in size"
 	`);
 	});
 

packages/wrangler/src/__tests__/r2.test.ts

@@ -316,9 +316,10 @@ describe("r2", () => {
 				)
 			).rejects.toThrowErrorMatchingInlineSnapshot(`
 			"Error: Wrangler only supports uploading files up to ${prettyBytes(
-				MAX_UPLOAD_SIZE
+				MAX_UPLOAD_SIZE,
+				{ binary: true }
 			)} in size
-			wormhole-img.png is ${prettyBytes(TOO_BIG_FILE_SIZE)} in size"
+			wormhole-img.png is ${prettyBytes(TOO_BIG_FILE_SIZE, { binary: true })} in size"
 		`);
 		});
 

packages/wrangler/src/pages/validate.tsx

@@ -94,8 +94,11 @@ export const validate = async (args: {
 					if (filestat.size > MAX_ASSET_SIZE) {
 						throw new FatalError(
 							`Error: Pages only supports files up to ${prettyBytes(
-								MAX_ASSET_SIZE
-							)} in size\n${name} is ${prettyBytes(filestat.size)} in size`,
+								MAX_ASSET_SIZE,
+								{ binary: true }
+							)} in size\n${name} is ${prettyBytes(filestat.size, {
+								binary: true,
+							})} in size`,
 							1
 						);
 					}

packages/wrangler/src/r2/index.ts

@@ -262,8 +262,11 @@ export function r2(r2Yargs: CommonYargsArgv) {
 						if (objectSize > MAX_UPLOAD_SIZE) {
 							throw new FatalError(
 								`Error: Wrangler only supports uploading files up to ${prettyBytes(
-									MAX_UPLOAD_SIZE
-								)} in size\n${key} is ${prettyBytes(objectSize)} in size`,
+									MAX_UPLOAD_SIZE,
+									{ binary: true }
+								)} in size\n${key} is ${prettyBytes(objectSize, {
+									binary: true,
+								})} in size`,
 								1
 							);
 						}