-
Notifications
You must be signed in to change notification settings - Fork 869
During Pages and R2 validation, show sizes in MiB (consistently with our docs) #4577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 53f59c6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7144642989/npm-package-wrangler-4577 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7144642989/npm-package-wrangler-4577 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7144642989/npm-package-wrangler-4577 dev path/to/script.js Additional artifacts:npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7144642989/npm-package-miniflare-4577 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7144642989/npm-package-cloudflare-pages-shared-4577 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7144642989/npm-package-create-cloudflare-4577 Note that these links will no longer work once the GitHub Actions artifact expires.
| Please ensure constraints are pinned, and |
MAX_ASSET_SIZE
consistently as per docs
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4577 +/- ##
==========================================
+ Coverage 75.41% 75.43% +0.01%
==========================================
Files 241 241
Lines 12867 12867
Branches 3315 3315
==========================================
+ Hits 9704 9706 +2
+ Misses 3163 3161 -2
|
resolves #4519