Skip to content

During Pages and R2 validation, show sizes in MiB (consistently with our docs) #4577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Dec 8, 2023

Conversation

dario-piotrowicz
Copy link
Member

resolves #4519

@dario-piotrowicz dario-piotrowicz requested review from a team as code owners December 8, 2023 13:08
Copy link

changeset-bot bot commented Dec 8, 2023

🦋 Changeset detected

Latest commit: 53f59c6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
wrangler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Dec 8, 2023

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7144642989/npm-package-wrangler-4577

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7144642989/npm-package-wrangler-4577

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7144642989/npm-package-wrangler-4577 dev path/to/script.js
Additional artifacts:
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7144642989/npm-package-miniflare-4577
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7144642989/npm-package-cloudflare-pages-shared-4577
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7144642989/npm-package-create-cloudflare-4577

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20231030.3
workerd 1.20231030.0 1.20231030.0
workerd --version 1.20231030.0 2023-10-30

|

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@dario-piotrowicz dario-piotrowicz changed the title During the pages validation, show MAX_ASSET_SIZE consistently as per docs During Pages and R2 validation, show sizes in MiB (consistently with our docs) Dec 8, 2023
Copy link

codecov bot commented Dec 8, 2023

Codecov Report

Merging #4577 (53f59c6) into main (eb08e2d) will increase coverage by 0.01%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4577      +/-   ##
==========================================
+ Coverage   75.41%   75.43%   +0.01%     
==========================================
  Files         241      241              
  Lines       12867    12867              
  Branches     3315     3315              
==========================================
+ Hits         9704     9706       +2     
+ Misses       3163     3161       -2     
Files Coverage Δ
packages/wrangler/src/pages/validate.tsx 95.74% <ø> (ø)
packages/wrangler/src/r2/index.ts 87.42% <ø> (ø)

... and 5 files with indirect coverage changes

@dario-piotrowicz dario-piotrowicz merged commit 4c85fe9 into main Dec 8, 2023
@dario-piotrowicz dario-piotrowicz deleted the mib branch December 8, 2023 18:28
@workers-devprod workers-devprod mentioned this pull request Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 BUG: Fix Cloudflare pages supports 30 mb
2 participants