Skip to content

Feature link names #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

pontusarfwedson
Copy link
Contributor

Added functionality to be able to set link_names as parameter in pipeline with it defaulting to false. Also modified the tests so they actually pass with the new added parameter. Has been tested in a pipeline with successfully notified user group by writing @ which then mentioned the group. Was tested by using

resource_types:
- name: slack-notification
  type: docker-image
  source:
    repository: quay.io/pontusarfwedson/slack-notification-resource
    tag: feature-link-names

in our pipeline (which points to a docker image build from this exact branch).

Difference from latest PR is that we now do not have a missing comma in the json in the out file and also the tests has been altered to include the new param.

@drnic drnic merged commit c847987 into cloudfoundry-community:master Mar 23, 2018
@drnic
Copy link
Contributor

drnic commented Mar 23, 2018

Thanks!

drnic added a commit that referenced this pull request Mar 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants