-
Notifications
You must be signed in to change notification settings - Fork 217
Use golang/protobuf instead of gogo/protobuf #992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
ebroberson
wants to merge
51
commits into
develop
Choose a base branch
from
protobuf-with-plugin
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
51 commits
Select commit
Hold shift + click to select a range
5475233
Remove gogoprotobuf in favor of google protobuf
ebroberson 256c3c8
Clean go.mod
ebroberson eede90e
Bump https://github.com/jqlang/jq/releases/tag/jq-1.7
tas-runtime-bot 5ca3aaf
Bump https://github.com/rprichard/winpty/releases/tag/0.4.2
tas-runtime-bot e7b89e8
Bump bbs (remove old protobuf models)
ebroberson 0d670d3
bump credhub-cli
tas-runtime-bot c684e01
Update go.mod dependencies
tas-runtime-bot be84a43
Sync package specs
tas-runtime-bot e18fde7
Bump bbs, executor, rep, garden, grootfs, guardian, idmapper (file-based
ebroberson bdf45ce
Merge branch 'develop' into protobuf-with-plugin
ebroberson a618402
Bump bbs
ebroberson e6ed406
Fix .final_builds yaml for golang
ebroberson 641f6bd
Add credhub-cli branch to .gitmodules
ebroberson a4213d0
Bump locket, executor
ebroberson b332c16
Attempt to remove SidecarRootFS changes
ebroberson 32ebbf4
Bump credhub-cli, executor, rep, grootfs
ebroberson 3778df5
Merge branch 'develop' into protobuf-with-plugin
ebroberson 7dd2113
Bump inigo (force-undo revert)
ebroberson 90ebd5c
Bump bbs (performance tests)
ebroberson bc08dfa
Bump bbs, locket (new backwards-compatible locket protobufs)
ebroberson 594f3cb
Sync locket spec
ebroberson 5ebb364
Bump bbs, locket
ebroberson b168545
Bump auctioneer, cfdot, rep, route-emitter, routing-api
ebroberson 8cff32b
Bump bbs, locket (regen protos)
ebroberson 80bf1e1
Bump locket
ebroberson 38e66c3
Bump bbs, locket
ebroberson f2623cf
Bump actioneer, bbs, buildpackapplifecycle, cacheddownloader, cfdot, …
ebroberson dc69510
Merge develop into protobuf-with-plugin
ebroberson 52de130
Bump bbs
ebroberson 1e5cd3f
Bump bbs, locket
ebroberson d9f152a
Upgrade golang-1.23-linux (1.23.8)
tas-runtime-bot 52c3f0a
Upgrade golang-1.23-windows (1.23.8)
tas-runtime-bot c819460
bump credhub-cli garden grootfs guardian idmapper
tas-runtime-bot f68d4b4
Update go.mod dependencies
tas-runtime-bot c68408a
Sync package specs
tas-runtime-bot 11a2677
Bump bbs, inigo, rep, garden, grootfs, guardian, idmapper
ebroberson 805e74f
Merge branch 'develop' into protobuf-with-plugin
ebroberson 4668b76
go mod tidy && go mod vendor
ebroberson 8458a79
bump credhub-cli garden grootfs guardian idmapper
tas-runtime-bot c5453d1
Update go.mod dependencies
tas-runtime-bot c877780
Bump locket (regen certs)
ebroberson 95599b8
Bump+merge submodules
ebroberson 73cd7a9
Merge branch 'develop' into protobuf-with-plugin
ebroberson 510b253
Bump bbs
ebroberson 268faa4
Upgrade golang-1.24-linux (1.24.2)
tas-runtime-bot 2bf3c12
Upgrade golang-1.24-windows (1.24.2)
tas-runtime-bot a22f16a
Upgrade golang-1.24-linux (1.24.3)
tas-runtime-bot 11e5dfc
Upgrade golang-1.24-windows (1.24.3)
tas-runtime-bot 55615da
Bump bbs, locket
ebroberson c177ac3
Bump bbs (skip perf tests)
ebroberson ea5208e
Bump bbs (task reuse fix)
ebroberson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,39 +5,39 @@ | |
[submodule "src/code.cloudfoundry.org/bbs"] | ||
path = src/code.cloudfoundry.org/bbs | ||
url = https://github.com/cloudfoundry/bbs | ||
branch = main | ||
branch = protobuf-with-plugin | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. These should all get updated back to main before merging |
||
[submodule "src/code.cloudfoundry.org/auctioneer"] | ||
path = src/code.cloudfoundry.org/auctioneer | ||
url = https://github.com/cloudfoundry/auctioneer | ||
branch = main | ||
branch = protobuf-with-plugin | ||
[submodule "src/code.cloudfoundry.org/cacheddownloader"] | ||
path = src/code.cloudfoundry.org/cacheddownloader | ||
url = https://github.com/cloudfoundry/cacheddownloader | ||
branch = main | ||
[submodule "src/code.cloudfoundry.org/executor"] | ||
path = src/code.cloudfoundry.org/executor | ||
url = https://github.com/cloudfoundry/executor | ||
branch = main | ||
branch = protobuf-with-plugin | ||
[submodule "src/code.cloudfoundry.org/healthcheck"] | ||
path = src/code.cloudfoundry.org/healthcheck | ||
url = https://github.com/cloudfoundry/healthcheck | ||
branch = main | ||
[submodule "src/code.cloudfoundry.org/inigo"] | ||
path = src/code.cloudfoundry.org/inigo | ||
url = https://github.com/cloudfoundry/inigo | ||
branch = main | ||
branch = protobuf-with-plugin | ||
[submodule "src/code.cloudfoundry.org/locket"] | ||
path = src/code.cloudfoundry.org/locket | ||
url = https://github.com/cloudfoundry/locket | ||
branch = main | ||
branch = protobuf-with-plugin | ||
[submodule "src/code.cloudfoundry.org/rep"] | ||
path = src/code.cloudfoundry.org/rep | ||
url = https://github.com/cloudfoundry/rep | ||
branch = main | ||
branch = protobuf-with-plugin | ||
[submodule "src/code.cloudfoundry.org/vizzini"] | ||
path = src/code.cloudfoundry.org/vizzini | ||
url = https://github.com/cloudfoundry/vizzini | ||
branch = main | ||
branch = protobuf-with-plugin | ||
[submodule "src/code.cloudfoundry.org/buildpackapplifecycle"] | ||
path = src/code.cloudfoundry.org/buildpackapplifecycle | ||
url = https://github.com/cloudfoundry/buildpackapplifecycle | ||
|
@@ -53,19 +53,19 @@ | |
[submodule "src/code.cloudfoundry.org/diego-ssh"] | ||
path = src/code.cloudfoundry.org/diego-ssh | ||
url = https://github.com/cloudfoundry/diego-ssh | ||
branch = main | ||
branch = protobuf-with-plugin | ||
[submodule "src/code.cloudfoundry.org/route-emitter"] | ||
path = src/code.cloudfoundry.org/route-emitter | ||
url = https://github.com/cloudfoundry/route-emitter | ||
branch = main | ||
branch = protobuf-with-plugin | ||
[submodule "src/code.cloudfoundry.org/operationq"] | ||
path = src/code.cloudfoundry.org/operationq | ||
url = https://github.com/cloudfoundry/operationq | ||
branch = main | ||
[submodule "src/code.cloudfoundry.org/cfdot"] | ||
path = src/code.cloudfoundry.org/cfdot | ||
url = https://github.com/cloudfoundry/cfdot | ||
branch = main | ||
branch = protobuf-with-plugin | ||
[submodule "src/code.cloudfoundry.org/volman"] | ||
path = src/code.cloudfoundry.org/volman | ||
url = https://github.com/cloudfoundry/volman | ||
|
@@ -80,11 +80,11 @@ | |
[submodule "src/code.cloudfoundry.org/routing-info"] | ||
path = src/code.cloudfoundry.org/routing-info | ||
url = https://github.com/cloudfoundry-incubator/routing-info | ||
branch = main | ||
branch = protobuf-with-plugin | ||
[submodule "src/code.cloudfoundry.org/routing-api"] | ||
path = src/code.cloudfoundry.org/routing-api | ||
url = https://github.com/cloudfoundry-incubator/routing-api | ||
branch = main | ||
branch = protobuf-with-plugin | ||
[submodule "src/code.cloudfoundry.org/guardian"] | ||
path = src/guardian | ||
url = https://github.com/cloudfoundry/guardian | ||
|
@@ -105,6 +105,7 @@ | |
[submodule "src/code.cloudfoundry.org/credhub-cli"] | ||
path = src/code.cloudfoundry.org/credhub-cli | ||
url = https://github.com/cloudfoundry-incubator/credhub-cli/ | ||
branch = main | ||
[submodule "src/garden"] | ||
path = src/garden | ||
url = https://github.com/cloudfoundry/garden | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,2 @@ | ||
name: golang-1.24-linux | ||
fingerprint: d742dc5eebc66113a186db2c1446ff5d646524cc798d1e74a56b684cffc53d35 | ||
fingerprint: e75c69bba41945ce0ae901b68cdcb641b624f373fb0f63f282acc8d138ca27d2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,2 @@ | ||
name: golang-1.24-windows | ||
fingerprint: 969cd732a518cb6d8ace3f5adb6d3c4b033bce07066d86c0019f4f339630407f | ||
fingerprint: 0151b9c91ab94dbf9a6fd4319f5f828184fa40f3eb1d934366fe77901bdc328d |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes to all the .final_builds/packages concern me here. We should keep whatever's on main rather than the protobuf branch, right?