Indicate if a Service Instance is still usable after a failed update or deprovisioning and if an update can be repeated #661
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Hey fmui! The commit authors and yourself have already signed the CLA. |
jberkhahn
reviewed
May 28, 2019
spec.md
Outdated
| @@ -1734,6 +1760,14 @@ $ curl 'http://username:password@service-broker-url/v2/service_instances/:instan | |||
| Responses with any other status code MUST be interpreted as a failure and the | |||
| Platform MUST remember the Service Instance. | |||
|
|
|||
| When a deprovisioning fails, the Service Instance can still be usable or | |||
| unusable or its state could be unknown. If a Service Instance became unusable, | |||
| the Platform SHOULD NOT allow the creation of new bindings. | |||
There was a problem hiding this comment.
I'm not sure if this is just me being pedantic, but don't we generally try to describe things in terms of the platform/broker relationship? As currently worded, this seems to be more describing the internal behavior of the platform itself. Wouldn't it make more sense if it was worded something like "If a Service Instance becomes unusable the Platform SHOULD NOT request new Service Bindings for that Service Instance."
There was a problem hiding this comment.
Good point. I've changed that sentence.
jberkhahn
approved these changes
May 29, 2019
|
Looks good from SAPI point of view. |
mattmcneeney
approved these changes
Jun 25, 2019
|
@tinygrasshopper we need your vote! |
|
✅ Hey fmui! The commit authors and yourself have already signed the CLA. |
tinygrasshopper
approved these changes
Jul 23, 2019
gberche-orange
added a commit
to orange-cloudfoundry/osb-cmdb
that referenced
this pull request
Apr 26, 2021
* [ ] Test update https://github.com/openservicebrokerapi/servicebroker/blob/master/spec.md#response-5 * [x] Implement update error recovery * Check si, if an update operation is in progress, then return 202 accepted, * otherwise 500 bad request if update request was previously accepted * otherwise 400 bad request otherwise * OSB api v2.16 will be supporting error details such as "usable", see cloudfoundry/servicebroker#661 * But not yet implemented in CF API v3 http://v3-apidocs.cloudfoundry.org/version/3.83.0/index.html#create-a-service-instance * Nor in SC-OSB * [x] Refine USI sync success test: sync update will trigger a new backing update and not enter error recovery branch, just perform the update twise * [x] OSB provision dupl same SI: check same dupl receives right status * [x] 200 Ok as backing service was completed
gberche-orange
added a commit
to orange-cloudfoundry/osb-cmdb
that referenced
this pull request
Apr 26, 2021
…ate + handle invalid plan/service-definion id * [x] Test update https://github.com/openservicebrokerapi/servicebroker/blob/master/spec.md#response-5 * [x] Implement update error recovery * Check si, if an update operation is in progress, then return 202 accepted, * otherwise 500 bad request if update request was previously accepted * otherwise 400 bad request otherwise * OSB api v2.16 will be supporting error details such as "usable", see cloudfoundry/servicebroker#661 * But not yet implemented in CF API v3 http://v3-apidocs.cloudfoundry.org/version/3.83.0/index.html#create-a-service-instance * Nor in SC-OSB * [x] Refine USI sync success test: sync update will trigger a new backing update and not enter error recovery branch, just perform the update twise * [x] OSB provision dupl same SI: check same dupl receives right status * [x] 200 Ok as backing service was completed * [x] Check UpdateAsyncInstanceWithBackingServiceAcceptanceTest does * [x] USI * [x] OSB provision dupl same SI: check same dupl receives right status * [x] 202 accepted, and then 200 * [x] New concurrent stalled Update async test (ConcurrentAsyncUpdateInstanceWithBackingServiceAcceptanceTest) that does * [x] New interceptor StalledAsyncUpdate * [x] USI * [x] OSB provision dupl same SI: check same dupl receives right status * [x] 202 Accepted as backing service is still in progress * [x] OSB update with invalid plan * [x] 400 Bad request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem this PR solves?
This PR is a subset of PR #637. It only contains the non-controversial
instance_usableandupdate_repeatableflags.Checklist: